feat(button): rework component on top of @base-ui/react - #383
Open
H4ad wants to merge 1 commit into
Open
Conversation
H4ad
force-pushed
the
feat/rework-button-component
branch
from
September 6, 2026 23:54
2995958 to
b518ac4
Compare
H4ad
force-pushed
the
feat/rework-button-component
branch
from
September 7, 2026 01:02
b518ac4 to
1e231f0
Compare
H4ad
changed the base branch from
feat/rework-tooltip-component
to
feat/add-spinner-component
September 7, 2026 20:56
H4ad
force-pushed
the
feat/rework-button-component
branch
from
September 7, 2026 20:56
1e231f0 to
f3c69ce
Compare
H4ad
marked this pull request as ready for review
September 7, 2026 20:56
H4ad
marked this pull request as draft
September 7, 2026 21:01
H4ad
force-pushed
the
feat/rework-button-component
branch
3 times, most recently
from
September 8, 2026 14:22
b0a5be7 to
c1f42a7
Compare
H4ad
commented
Sep 8, 2026
Contributor
Author
There was a problem hiding this comment.
I will rework this later entirely, for now, we can keep this basic doc, this will change a lot after the doc proposal/layout
H4ad
commented
Sep 8, 2026
|
|
||
| ## How to use | ||
|
|
||
| `variant`, `color`, `size` and the children are all required: the button has no default |
Contributor
Author
There was a problem hiding this comment.
I did this intentionally to help agents figure out what that button represents and how it looks like
H4ad
force-pushed
the
feat/rework-button-component
branch
from
September 8, 2026 15:50
c1f42a7 to
5f31a2d
Compare
H4ad
marked this pull request as ready for review
September 8, 2026 20:23
H4ad
force-pushed
the
feat/rework-button-component
branch
from
September 8, 2026 20:24
5f31a2d to
9c27d1e
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
This reworks the button to follow the guidelines of https://github.com/SigNoz/engineering-pod/issues/5983
Closes https://github.com/SigNoz/engineering-pod/issues/6010
Component checklist
Philosophy (guidelines)
Structure (guidelines)
packages/ui/src/, matches the export subpathindex.tsonly re-exports (+ generated token region);export type *plus explicit named exports.jsextension; types imported withimport typesubcomponents/, opinionated compositions inpresets/src/index.ts,vite.config.ts,package.jsonexports,README.md+intro.mdxexternalPatternsCSS (guidelines)
{name}.module.scss, no Tailwind, no CVA, no Sass variablesvar(--{component}-x, <design token>); no hardcoded valuesvar(--spacing-4, 8px)); a bare literal only where no token matches--bg-*/--text-*primitives referenced from a component--{component}-internal-*--x: var(--x)and no duplicated variable definitionsdata-*attributes;data-slotanddata-testidon the rootcolor-mix()for derived shades, neverrgba()over a token:hover,:focus-visible,aria-invalid, disabled all styled@media (prefers-reduced-motion: reduce)pnpm run tokensrun and theindex.tsregion committedVisual QA (guidelines)
parameters.designsmmatchesButton/Input)Typographyor the type-scale tokens, not an ad-hocfont-size/font-weight@signozhq/icons, sized with tokens, no inline SVG with hardcodedpxTypes (guidelines)
{Component}Propsexported; only the props the component actually needs are exposedOriginalProps['x']), never restated by handindex.tsforwardRef+displayName;asChild,testIdsupportedDocs (guidelines)
@defaultwhere applicabletitlegroupargTypescomplete withcategory,type.summary,defaultValue.summary{component}.mdxwith a usage snippet and a<Controls>per exported pieceTests (guidelines)
forward-reftestrun-visual-testinglabel added if the change is visual